Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recreate AEH Processor in the event of an error before retrying the processing operation #3614

Merged
merged 12 commits into from
Dec 17, 2024

Conversation

MattCosturos
Copy link
Contributor

@MattCosturos MattCosturos commented Nov 26, 2024

Recreate AEH Processor in the event of an error before retrying the processing operation

Description

Moved the creation and setup of the Azure Event Hub Processor inside the main loop.
The processor.run only returns a non-recoverable error. Therefore we must re-create new processor and setup the subscription.

Issue reference

We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.

Please reference the issue this PR will close: #3573

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Created/updated tests
  • Extended the documentation / Created issue in the https://github.com/dapr/docs/ repo: dapr/docs#[issue number]

Recreate AEH Processor in the event of an error before retrying the processing operation

Signed-off-by: MattCosturos <[email protected]>
@MattCosturos MattCosturos requested review from a team as code owners November 26, 2024 14:28
@yaron2
Copy link
Member

yaron2 commented Nov 26, 2024

See failing build tests

@MattCosturos
Copy link
Contributor Author

MattCosturos commented Nov 26, 2024

Updated to log the initial connection error, and then retry after 5 seconds. Same way we handle errors after the initial creation.

@yaron2
Copy link
Member

yaron2 commented Dec 13, 2024

/ok-to-test

@dapr-bot
Copy link
Collaborator

Complete Build Matrix

The build status is currently not updated here. Please visit the action run below directly.

🔗 Link to Action run

Commit ref: 3a2da6f

@dapr-bot
Copy link
Collaborator

dapr-bot commented Dec 13, 2024

Components conformance test

🔗 Link to Action run

Commit ref: 3a2da6f

❌ Some conformance tests failed

These tests failed:

  • bindings.azure.eventgrid
  • state.azure.cosmosdb
  • state.postgresql.v1.azure

@dapr-bot
Copy link
Collaborator

dapr-bot commented Dec 13, 2024

Components certification test

🔗 Link to Action run

Commit ref: 3a2da6f

❌ Some certification tests failed

These tests failed:

  • bindings.kitex
  • pubsub.gcp.pubsub
  • state.azure.cosmosdb
  • state.sqlserver

@yaron2
Copy link
Member

yaron2 commented Dec 17, 2024

@artursouza for last review

@artursouza artursouza changed the base branch from main to release-1.5 December 17, 2024 15:20
@artursouza artursouza changed the base branch from release-1.5 to main December 17, 2024 15:20
@yaron2 yaron2 merged commit 26808c9 into dapr:main Dec 17, 2024
57 checks passed
@MattCosturos MattCosturos deleted the patch-1 branch December 17, 2024 20:03
@marcduiker
Copy link
Contributor

@holopin-bot @MattCosturos Thank you!

Copy link

holopin-bot bot commented Jan 10, 2025

Congratulations @MattCosturos, the maintainer of this repository has issued you a badge! Here it is: https://holopin.io/claim/cm5qy4cgt31630cmjrmpc4am6

This badge can only be claimed by you, so make sure that your GitHub account is linked to your Holopin account. You can manage those preferences here: https://holopin.io/account.
Or if you're new to Holopin, you can simply sign up with GitHub, which will do the trick!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Azure Event Hub binding stops working if storage act returns 503
5 participants